Comments on: How to refresh listeners in Prototype

By: kangax

kangax — Tue, 17 Jun 2008 19:32:51 +0000

I see your point.
Event delegation is obviously not a silver bullet.
It could be very well not worth it, but performing a tiny operation on every click usually leads to a better performance (vs. having N event handlers in memory)

By: Garrett

Garrett — Mon, 16 Jun 2008 22:30:39 +0000

Maybe not a memory leak, but just the overall viewpoint of it…listening to every click where its not needed, over listening to double clicks on elements that are needed should be targeted that way. That is were I think the if statements are bloated and not needed.

Let me mention that I changed my double click listener to a simple single for this post.

By: kangax

kangax — Mon, 16 Jun 2008 21:52:34 +0000

I don’t see why there would be a leak. There seems to be no circular references created (if you are referring to IE’ s bug). I’ve been using event delegation for quite some time lately and performance gains are usually pretty noticeable.

- kangax

By: Garrett

Garrett — Mon, 16 Jun 2008 04:34:28 +0000

Won’t there be a memory leak over time, listening to every click and doing if statements all over? Instead of adding the listener to the actual element?

By: kangax

kangax — Sun, 15 Jun 2008 20:17:40 +0000

This is actually an overkill.
Event delegation seems more appropriate here.
Try this:

document.observe(‘click’, function(e) {
var target = e.findElement(‘tr[rel=file]‘);
if(!target) return;
e.stop();
// send request, etc.
})

Best,
kangax